Merged
Conversation
gui1117
commented
Mar 30, 2026
| #[command(about = "Distributed statement store latency benchmark", long_about = None)] | ||
| struct Args { | ||
| /// Comma-separated list of RPC WebSocket endpoints (e.g., ws://node1:9944,ws://node2:9944) | ||
| /// Comma-separated list of RPC WebSocket endpoints (e.g., `ws://node1:9944,ws://node2:9944`) |
Contributor
Author
There was a problem hiding this comment.
this was interpreted as file ws:/node... by lychee.
gui1117
commented
Mar 30, 2026
| "%7B%7D", | ||
| "%7B:\\?}", | ||
| # Example ws:// URLs in Rust doc comments incorrectly parsed as file paths by lychee | ||
| "file://.*/ws:/node.*", |
Contributor
Author
There was a problem hiding this comment.
according to claude, lychee is broken for //! doc and it can't parse and exclude the ```bash part
gui1117
added
R0-no-crate-publish-required
bkchr
approved these changes
Mar 30, 2026
muharem
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.